Exam report: Avoid loading on question change

[AlexVelezLl]

Summary

Avoid fetching exam resources again if they are already loaded.

References

Closes #12062

Screenshots

Compartir.pantalla.-.2024-04-12.11_29_17.mp4

Reviewer guidance

1. Take an exam as a learner.
2. Review different exam reports and check that everything is loading correctly.
3. Switch between questions, attempts and question interactions and the loading state should not appear

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.1a0.dev0_git.10.ge5d03fc7.pex
Windows Installer (EXE)	kolibri-0.16.1a0.dev0+git.10.ge5d03fc7-windows-setup-unsigned.exe
Debian Package	kolibri_0.16.1a0.dev0+git.10.ge5d03fc7-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.1a0.dev0+git.10.ge5d03fc7-0.4.0.dmg
Android Package (APK)	kolibri-0.16.1a0.dev0+git.10.ge5d03fc7-0.1.1-debug.apk
TAR file	kolibri-0.16.1a0.dev0+git.10.ge5d03fc7.tar.gz
WHL file	kolibri-0.16.1a0.dev0+git.10.ge5d03fc7-py2.py3-none-any.whl

[marcellamaki]

The code read through makes sense to me, @AlexVelezLl - thanks for working on this. I also did a quick manual QA which checks out but I'll defer to @radinamatic and @pcenov for the final QA team approval.

My main thing that I'm still wondering is where exactly this regression came from, as this file hasn't been changed in years. My guess is that it was related to some of the other pretty significant loading state refactor work that went in to 0.16, and it's definitely possible that we just didn't notice it in the 0.16.0 QA. I'm just a bit mystified. This isn't blocking (or a criticism!) but I am wondering - did you discover anything about where the regression came from that led you to this solution in particular, or was it just a matter of looking at some of the handler patterns and deciding this would be the simplest path forward? Something else entirely? I realize you have less Past Knowledge of this part of the code base and what it looked like a while ago, so this is to satisfy my curiosity, mainly.

[pcenov]

Thanks @AlexVelezLl I confirm that the loading state of the quiz report when viewed as a learner is fixed now. However, while regression testing I noticed that this is not fixed at Coach > Reports so it will be great if you could fix it there as well:

2024-04-23_16-27-50.mp4

[AlexVelezLl]

Hi @marcellamaki. This regression comes from here. The reason why the scroll is reset is because we have this conditional rendering, this way the ExamReport is unmounted from the DOM and mounted again.

Previously, although the data was reloaded and the references were updated, the ExamReport was always visible. And since we loaded the same data it still looked the same.

We could keep the same behavior of reloading the data, and make the ExamReport always visible, but perhaps with some opacity while the circular loader is shown, and revert the change to look if it is loaded in vue, If that is safer.

[marcellamaki]

Thank you @AlexVelezLl! :)

@pcenov, I've opened a follow up issue for the coach reports loading state.