Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.16 into develop #12239

Merged
merged 11 commits into from
Jun 4, 2024
Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jun 4, 2024

Summary

This should be the final cascade merge into develop from release-v0.16.x

Conflicts mostly caused by the cherry pick commit, meaning the same changes are made on both branches in differently identified commits.

# Conflicts:
#	kolibri/core/static/assets/default_theme/background.jpg
#	kolibri/core/static/assets/default_theme/kolibri-logo-192.png
#	kolibri/core/static/assets/default_theme/kolibri-logo-512.png
#	kolibri/core/static/assets/default_theme/kolibri-logo.svg
#	kolibri/core/static/assets/default_theme/logo.ico
#	kolibri/core/static/assets/kolibri-logo-192.png
#	kolibri/core/static/assets/kolibri-logo-512.png
#	kolibri/core/static/assets/kolibri-logo.svg
#	kolibri/core/static/assets/logo.ico
#	kolibri/plugins/default_theme/kolibri_plugin.py
#	kolibri/plugins/default_theme/static/assets/default_theme/kolibri-logo-192.png
#	kolibri/plugins/default_theme/static/assets/default_theme/kolibri-logo-512.png
#	kolibri/plugins/default_theme/static/assets/default_theme/kolibri-logo.svg
#	kolibri/plugins/default_theme/static/assets/default_theme/logo.ico
#	kolibri/plugins/user_auth/assets/src/views/AuthBase.vue

rtibbles and others added 11 commits May 22, 2024 15:25
…nt_exist

Handle case when username doesn't exist on remote and try to create it.
…r_realz

Zip the whl file before uploading for BCK step.
Add transform to ensure proper layering in Safari.
# Conflicts:
#	kolibri/core/static/assets/default_theme/background.jpg
#	kolibri/core/static/assets/default_theme/kolibri-logo-192.png
#	kolibri/core/static/assets/default_theme/kolibri-logo-512.png
#	kolibri/core/static/assets/default_theme/kolibri-logo.svg
#	kolibri/core/static/assets/default_theme/logo.ico
#	kolibri/core/static/assets/kolibri-logo-192.png
#	kolibri/core/static/assets/kolibri-logo-512.png
#	kolibri/core/static/assets/kolibri-logo.svg
#	kolibri/core/static/assets/logo.ico
#	kolibri/plugins/default_theme/kolibri_plugin.py
#	kolibri/plugins/default_theme/static/assets/default_theme/kolibri-logo-192.png
#	kolibri/plugins/default_theme/static/assets/default_theme/kolibri-logo-512.png
#	kolibri/plugins/default_theme/static/assets/default_theme/kolibri-logo.svg
#	kolibri/plugins/default_theme/static/assets/default_theme/logo.ico
#	kolibri/plugins/user_auth/assets/src/views/AuthBase.vue
@rtibbles rtibbles requested a review from marcellamaki June 4, 2024 19:29
@rtibbles rtibbles added the TODO: needs review Waiting for review label Jun 4, 2024
@github-actions github-actions bot added DEV: dev-ops Continuous integration & deployment DEV: backend Python, databases, networking, filesystem... APP: User Re: User app (sign-in, sign-up, user profile, etc.) DEV: frontend SIZE: small labels Jun 4, 2024
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like we have all the correct commits included. smoke test running locally works fine

@marcellamaki marcellamaki merged commit 5f7ef8d into learningequality:develop Jun 4, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: User Re: User app (sign-in, sign-up, user profile, etc.) DEV: backend Python, databases, networking, filesystem... DEV: dev-ops Continuous integration & deployment DEV: frontend SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants