EQM: Difficult questions reports fix #12372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Coach
nucleogenesis
requested review from
rtibbles,
radinamatic,
pcenov and
marcellamaki
nucleogenesis
commented
Jun 27, 2024
Comment on lines
+27
to
+33
| icon="notStarted" | ||
| /> | ||
| <KIcon | ||
| v-else-if="!learner.correct" | ||
| class="item svg-item" | ||
| :style="{ fill: $themeTokens.incorrect }" | ||
| icon="cancel" | ||
| icon="incorrect" |
There was a problem hiding this comment.
This feels like it should be the right thing to use here... not sure why cancel was used for both of these icons. cancel no longer exists and I assume it's what turned into incorrect given the $themeToken that was used here.
notStartedis used when the learner has no attemptsincorrectis used when the user answered incorrectly (and presumably needs help)
Build Artifacts
|
|
Hi @nucleogenesis I confirm that now it's possible to see the details of the difficult questions however when I go to Coach > Reports > Lesson > Difficult questions I am not seeing the incorrect answers of the learner: 2024-06-27_16-23-53.mp4If that's not caused by the changes made here, I can file a follow-up issue. |
rtibbles
approved these changes
Jun 27, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #12164 - where questions were needed in
questionDetail/handlers.jswe were still expecting the Exam.question_sources v2 schema. I did a cursory search for possible other uses ofquestion_sourcesto derive questions but found nothing else.🎆 BONUS FIXES 🎆
Before:
Not all issues shown in screenshot
pxvaluesAfter:
Not all fixes shown in screenshot
emvaluesReviewer guidance