Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update automatic download setting default to False if running in a remote content context. #12395

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Update automatic download setting default to False if running in a remote content context. #12395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion kolibri/core/device/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
from kolibri.core.auth.models import FacilityUser
from kolibri.core.auth.permissions.base import RoleBasedPermissions
from kolibri.core.auth.permissions.general import IsOwn
from kolibri.core.content.utils.paths import using_remote_storage
from kolibri.core.device.utils import device_provisioned
from kolibri.core.device.utils import get_device_setting
from kolibri.core.fields import JSONField
Expand Down Expand Up @@ -117,7 +118,8 @@ def app_is_enabled():

extra_settings_default_values = {
"allow_download_on_metered_connection": False,
"enable_automatic_download": True,
# Default to not automatically downloading content if using remote storage
"enable_automatic_download": not using_remote_storage(),
"allow_learner_download_resources": False,
"set_limit_for_autodownload": False,
"limit_for_autodownload": 0,
Expand Down