Clean up some deprecation warnings #12469
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The migration to Django 3.2 left some deprecation warnings, this cleans up the following:
filter_fields
has been deprecated in favour offilterset_fields
copy.deepcopy()
from being set on the class object duringsetUpTestData
- the workaround for this is to do it insetUpClass
. If needed insetUpTestData
as it is here, this is done prior to the super call (during whichsetUpTestData
is called).get_filter_class
method in favour ofget_filterset_class
methodReferences
There is no open issue for this, I just got sick of seeing these warnings when running tests locally.
Reviewer guidance
If tests all pass, this should give some decent confidence - but I am targeting this to a patch release to defer the risk slightly.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)