Fix error that occurs if facilityDatasetExtraFields is null. #12534
Conversation
rtibbles
added this to the Kolibri 0.17: General maintenance, bugs, misc. important fixes milestone
Build Artifacts
|
| @@ -41,7 +41,7 @@ | |||
| }, | |||
| computed: { | |||
| customSchema() { | |||
| return this.facilityDatasetExtraFields.demographic_fields || []; | |||
| return this.facilityDatasetExtraFields?.demographic_fields || []; | |||
There was a problem hiding this comment.
If we allow facilityDatasetExtraFields to be null. Then this prop should not be marked as required right? https://github.com/rtibbles/kolibri/blob/787162af96d4af31dc23ec06d370692524679c42/packages/kolibri-common/components/ExtraDemographics/index.vue#L35
There was a problem hiding this comment.
I mean, it is required - it's just that VueJS prop validation doesn't actually do anything in production, it's advisory to ensure that developers are using props appropriately. The issue arises because a value is passed in for the prop, but the value is null.
There was a problem hiding this comment.
Oh, well that makes sense haha, thanks!
|
Tested user creation (all types), user properties editing, user deletion, class assignment, both on the original and one newly created additional facility. All is 🟢 to go! 👏🏽 🚀 |
Summary
References
Fixes #12533
Reviewer guidance
Make sure that you can still load the demographic editing in the user editing in the admin UI.
Testing checklist
PR process
Reviewer checklist
yarnandpip)