Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded future imports #12540

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Aug 7, 2024

Summary

Deletes the following future imports from the codebase:

  • division
  • absolute_import
  • with_statement
  • print_function
  • unicode_literals

As can be seen from here: https://docs.python.org/3/library/__future__.html#module-contents all of these language features have been mandatory since Python 3 (the with statement since Python 2.6), so there is no longer any need to import these futures to enforce this behaviour.

References

Further follow up after dropping Python 2.7

Reviewer guidance

All the Python tests passing should be sufficient.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added this to the Kolibri 0.17: Planned Patch 1 milestone Aug 7, 2024
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... DEV: tools Internal tooling for development labels Aug 7, 2024
Copy link
Member

@AllanOXDi AllanOXDi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I am only wondering why the documentation still mentions using from __future__ import unicode_literals for Django migrations. Since this PR removes future imports as they're no longer needed . Is this guidance is still necessary, or it should be updated to reflect the removal of __future__ imports?

@rtibbles
Copy link
Member Author

Good point, @AllanOXDi - that can be removed as well. Will update!

@rtibbles
Copy link
Member Author

Updated!

Copy link
Member

@AllanOXDi AllanOXDi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rtibbles rtibbles merged commit fbf35fc into learningequality:release-v0.17.x Aug 27, 2024
34 checks passed
@rtibbles rtibbles deleted the no_future_no_future_no_future_for_me branch August 27, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... DEV: tools Internal tooling for development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants