-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded future imports #12540
Remove unneeded future imports #12540
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I am only wondering why the documentation still mentions using from __future__ import unicode_literals
for Django migrations. Since this PR removes future imports as they're no longer needed . Is this guidance is still necessary, or it should be updated to reflect the removal of __future__
imports?
Good point, @AllanOXDi - that can be removed as well. Will update! |
Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Summary
Deletes the following future imports from the codebase:
As can be seen from here: https://docs.python.org/3/library/__future__.html#module-contents all of these language features have been mandatory since Python 3 (the with statement since Python 2.6), so there is no longer any need to import these futures to enforce this behaviour.
References
Further follow up after dropping Python 2.7
Reviewer guidance
All the Python tests passing should be sufficient.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)