Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating composable for connection monitoring and replacing existing logic with it #12584

Merged

Conversation

nathanaelg16
Copy link
Contributor

@nathanaelg16 nathanaelg16 commented Aug 21, 2024

Summary

This change creates a new composable for connection monitoring and migrates existing logic to use the new composable.

References

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@nathanaelg16 nathanaelg16 marked this pull request as ready for review August 21, 2024 22:50
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the correct approach, and the tests have been nicely updated to handle the new code. One small piece of cleanup, and I'll do some manual testing and closer review soon!

kolibri/core/assets/src/composables/useConnection.js Outdated Show resolved Hide resolved
@rtibbles rtibbles self-assigned this Aug 21, 2024
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, manual testing checks out. Snackbar properly displays in disconnected state, reconnect time does appropriate back off behaviour, and reconnection happens as intended.

@rtibbles
Copy link
Member

Excellent work @nathanaelg16, very cleanly and neatly done!

@rtibbles rtibbles merged commit 6e61470 into learningequality:develop Aug 22, 2024
34 checks passed
@nathanaelg16 nathanaelg16 deleted the use_connection_composable branch August 22, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create composable for connection monitoring and replace existing logic with it
2 participants