-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating composable for connection monitoring and replacing existing logic with it #12584
Creating composable for connection monitoring and replacing existing logic with it #12584
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like the correct approach, and the tests have been nicely updated to handle the new code. One small piece of cleanup, and I'll do some manual testing and closer review soon!
…olibri into use_connection_composable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good, manual testing checks out. Snackbar properly displays in disconnected state, reconnect time does appropriate back off behaviour, and reconnection happens as intended.
Excellent work @nathanaelg16, very cleanly and neatly done! |
Summary
This change creates a new composable for connection monitoring and migrates existing logic to use the new composable.
References
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)