-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch from open to io.open for text file read/write #3769
switch from open to io.open for text file read/write #3769
Conversation
5c34aa8
to
b5ac271
Compare
b5ac271
to
5e40d57
Compare
Codecov Report
@@ Coverage Diff @@
## release-v0.10.x #3769 +/- ##
===================================================
- Coverage 76.74% 76.74% -0.01%
===================================================
Files 215 215
Lines 8991 8999 +8
Branches 1110 1110
===================================================
+ Hits 6900 6906 +6
- Misses 1856 1858 +2
Partials 235 235
Continue to review full report at Codecov.
|
hmm looks like it's not building... checking on it |
49b0e11
to
fe5cd8d
Compare
fe5cd8d
to
d91a9af
Compare
@indirectlylit the fix confirmed at the Windows 7. Non-english characters are now displaying properly. |
great! might also help with #2541 |
Summary
In learningequality/kolibri-installer-windows#72 we noticed that characters aren't being rendered properly in Windows using Python 3
This PR attempts to find all instances of
open
that were used on text files, and replace them withio.open
, using an explicit encoding.Reviewer guidance
Please check that this all makes sense
References
Contributor Checklist
Reviewer Checklist
yarn
andpip
)