Mark as complete fix again #9837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nucleogenesis
added
TODO: needs review
marcellamaki
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
This fixes the main problem of the option persisting, and the code looks fine, so this is good to merge. It doesn't address @pcenov's comment that
once it does disappear I'm still seeing the ellipsis button instead of directly showing the 'View information' icon to the right of the bookmarks icon
But for now, I think that can be non-blocking and can be addressed in a follow up issue, so that the other PRs that depend on rebasing on top of this can continue moving forward.
I think this is probably best handled in #9830 |
nucleogenesis
force-pushed
the
mark-as-complete-fix--again
branch
from
dca8d28 to
2c70bb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue that was merged in #9808 where the progress wasn't updating properly.
I've used the already existing "update progress" method which appears to do some other necessary business logic around properly updating. Also, it seems that the progress value must be a float because passing the int 1 resulted in it trying to update progress to 1.2 and it got mad.
References
Reviewer guidance
Code review should be pretty quick. For testing, please look at #9808 for more context.