-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusted positioning of elements when language is set to a RTL language #9963
Merged
marcellamaki
merged 10 commits into
learningequality:release-v0.15.x
from
LianaHarris360:rtl-language-handling
Jan 10, 2023
Merged
Adjusted positioning of elements when language is set to a RTL language #9963
marcellamaki
merged 10 commits into
learningequality:release-v0.15.x
from
LianaHarris360:rtl-language-handling
Jan 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcellamaki
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you @LianaHarris360 for all of the efforts on this :)
LGTM as well - no issues observed while manually testing this. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adjusts and corrects the transcript handling for RTL languages.
RTL-language transcripts with Kolibri set to an LRT language (Kolibri set to English, transcript in Arabic):

LTR-language transcripts with Kolibri set to an RTL language (Kolibri set to Arabic, transcript in English):

RTL-language transcripts with Kolibri set to an RTL language (Kolibri set to Arabic, transcript in Arabic):

References
Closes #6187
Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)