Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted positioning of elements when language is set to a RTL language #9963

Conversation

LianaHarris360
Copy link
Member

@LianaHarris360 LianaHarris360 commented Jan 4, 2023

Summary

This PR adjusts and corrects the transcript handling for RTL languages.

RTL-language transcripts with Kolibri set to an LRT language (Kolibri set to English, transcript in Arabic):
Screenshot 2023-01-05 at 4 19 35 PM

LTR-language transcripts with Kolibri set to an RTL language (Kolibri set to Arabic, transcript in English):
Screenshot 2023-01-05 at 4 21 39 PM

RTL-language transcripts with Kolibri set to an RTL language (Kolibri set to Arabic, transcript in Arabic):
Screenshot 2023-01-05 at 4 21 26 PM

References

Closes #6187

Reviewer guidance

  • View RTL-language transcripts with the app set to an LRT language
  • View LTR-language transcripts with the app set to an RTL language
  • View RTL-language transcripts with the app set to an RTL language
  • Verify if the transcript language directions are correct

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@LianaHarris360 LianaHarris360 linked an issue Jan 9, 2023 that may be closed by this pull request
@LianaHarris360 LianaHarris360 marked this pull request as ready for review January 9, 2023 21:14
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you @LianaHarris360 for all of the efforts on this :)

@marcellamaki marcellamaki merged commit 376c060 into learningequality:release-v0.15.x Jan 10, 2023
@pcenov
Copy link
Member

pcenov commented Jan 11, 2023

LGTM as well - no issues observed while manually testing this. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve handling of video transcripts with RTL languages
4 participants