Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap kmodal in for primary dialogue component #2935

Conversation

marcellamaki
Copy link
Member

Description

This PR replaces the PrimaryDialogue component in ChannelTokenModal with KModal. There were no files where ChannelTokenModal is referenced that needed to be updated as a result of these changes - just the main component itself.

Issue Addressed (if applicable)

Addresses KDS issue 153

Steps to Test

There are two places to access the token modal

  • First place: Open Channel Token Modal from the Channel list page by selecting "Copy Channel Token" from the menu on the bottom right corner

Screen Shot 2021-02-11 at 9 59 07 AM

  • Second place: Open Channel Token Modal from the Channel (TreeView) page by selecting "Get Token" from the menu on the top right corner

Screen Shot 2021-02-11 at 10 00 12 AM

Both options the modal should open and close without any issue, and you should be able to successfully copy the token.

Does this introduce any tech-debt items?

None that I am aware of

@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #2935 (42dd023) into develop (950e24f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2935   +/-   ##
========================================
  Coverage    84.85%   84.85%           
========================================
  Files          292      292           
  Lines        15338    15338           
========================================
  Hits         13015    13015           
  Misses        2323     2323           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2f4c9a...3c04c76. Read the comment docs.

@rtibbles
Copy link
Member

Superseded by #2984

@rtibbles rtibbles closed this Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants