fix: don't publish tags greater than 30 chars

.gitignore

@@ -65,10 +65,12 @@ docs/_build/
 # PyBuilder
 target/
 
-# virtualenv
+# virtualenv, pipenv
+.env
 venv
 .venv
 Pipfile
+Pipfile.lock
 
 Thumbs.db
 .DS_Store

contentcuration/contentcuration/tests/test_exportchannel.py

@@ -70,6 +70,13 @@ def setUp(self):
         new_video.parent = new_node
         new_video.save()
 
+        # Add a node with tags greater than 30 chars to ensure they get excluded.
+        new_video = create_node({'kind_id': 'video', 'tags': [{'tag_name': 'kolbasdasdasrissadasdwzxcztudio'}, {'tag_name': 'kolbasdasdasrissadasdwzxcztudi'},
+                                {'tag_name': 'kolbasdasdasrissadasdwzxc'}], 'title': 'kolibri tag test', 'children': []})
+        new_video.complete = True
+        new_video.parent = self.content_channel.main_tree
+        new_video.save()
+
         set_channel_icon_encoding(self.content_channel)
         self.tempdb = create_content_database(self.content_channel, True, None, True)
 
@@ -120,6 +127,14 @@ def test_contentnode_incomplete_not_published(self):
         for node in incomplete_nodes:
             assert kolibri_nodes.filter(pk=node.node_id).count() == 0
 
+    def test_tags_greater_than_30_excluded(self):
+        tag_node = kolibri_models.ContentNode.objects.filter(title='kolibri tag test').first()
+        published_tags = tag_node.tags.all()
+
+        assert published_tags.count() == 2
+        for t in published_tags:
+            assert len(t.tag_name) <= 30
+
     def test_contentnode_channel_id_data(self):
         channel = kolibri_models.ChannelMetadata.objects.first()
         nodes = kolibri_models.ContentNode.objects.all()

contentcuration/contentcuration/tests/views/test_views_internal.py

@@ -61,6 +61,7 @@ def _make_node_data(self):
             "source_domain": random_data.source_domain,
             "source_id": random_data.source_id,
             "author": random_data.author,
+            "tags": ["oer", "edtech"],
             "files": [
                 {
                     "size": fileobj.file_size,
@@ -109,13 +110,19 @@ def setUp(self):
         invalid_copyright_holder["title"] = "invalid_copyright_holder"
         invalid_copyright_holder["copyright_holder"] = ""
 
+        # Node with tag greater than 30 characters
+        invalid_tag_length = self._make_node_data()
+        invalid_tag_length["title"] = "invalid_tag_length"
+        invalid_tag_length["tags"] = ["abcd abcd abcd abcd abcd abcd", "abcde abcd abcd abcd abcd abcd", "abcdef abcd abcd abcd abcd abcd"]
+
         self.sample_data = {
             "root_id": self.root_node.id,
             "content_data": [
                 valid_node,
                 invalid_title_node,
                 invalid_license_description,
                 invalid_copyright_holder,
+                invalid_tag_length,
             ],
         }
         self.resp = self.admin_client().post(
@@ -176,6 +183,12 @@ def test_invalid_nodes_are_not_complete(self):
         self.assertFalse(node_2.complete)
         self.assertFalse(node_3.complete)
 
+    def test_tag_greater_than_30_chars_excluded(self):
+        node = ContentNode.objects.get(title="invalid_tag_length")
+        tags = node.tags.all()
+        for t in tags:
+            assert len(t.tag_name) <= 30
+
 
 class ApiAddExerciseNodesToTreeTestCase(StudioTestCase):
     """

contentcuration/contentcuration/utils/publish.py

@@ -646,7 +646,8 @@ def map_tags_to_node(kolibrinode, ccnode):
 
     for tag in ccnode.tags.all():
         t, _new = kolibrimodels.ContentTag.objects.get_or_create(pk=tag.pk, tag_name=tag.tag_name)
-        tags_to_add.append(t)
+        if len(t.tag_name) <= 30:
+            tags_to_add.append(t)
 
     kolibrinode.tags.set(tags_to_add)
     kolibrinode.save()

contentcuration/contentcuration/views/internal.py

@@ -643,9 +643,10 @@ def create_node(node_data, parent_node, sort_order):  # noqa: C901
         tag_data = node_data["tags"]
         if tag_data is not None:
             for tag in tag_data:
-                tags.append(
-                    ContentTag.objects.get_or_create(tag_name=tag, channel=channel)[0]
-                )
+                if len(tag) <= 30:
+                    tags.append(
+                        ContentTag.objects.get_or_create(tag_name=tag, channel=channel)[0]
+                    )
 
     if len(tags) > 0:
         node.tags.set(tags)