Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for editing an exercise after adding a thumbnail #3353

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Fix for editing an exercise after adding a thumbnail #3353

merged 1 commit into from
Mar 29, 2022

Conversation

d0sadata
Copy link
Contributor

@d0sadata d0sadata commented Mar 28, 2022

Summary

Resolves #3158
The issue was a check order that wasn't executed properly, Misha helped me find it and solve it.
the order now first checks if the validation for file upload is required for exerice files or not.

Manual verification steps performed

  1. Tested on local environment

Reviewer guidance

Same as the issue reporting, create a new Exercise,
Add a thumbnail
Go to save

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

switched if check order.
@d0sadata d0sadata added the bug label Mar 28, 2022
@d0sadata d0sadata requested review from MisRob and sairina March 28, 2022 14:21
@d0sadata d0sadata self-assigned this Mar 28, 2022
@sairina
Copy link
Contributor

sairina commented Mar 28, 2022

@pcenov, this PR seems to fix the issue you described in #3158 ; however, I noticed that there's a follow-up problem (not necessarily related to this fix) where if a user then deletes the thumbnail and saves/clicks on "Finish", when the user is back on the channel editing page, the thumbnail that was deleted is still there. Would you mind checking to see if this is an issue, as well?

Copy link
Contributor

@sairina sairina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - this change fixes the reported issue.

Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @d0sadata

@sairina sairina merged commit cd6ef4d into learningequality:unstable Mar 29, 2022
@d0sadata d0sadata deleted the thumbnail-issues branch April 1, 2022 06:50
@d0sadata d0sadata removed their assignment Aug 21, 2022
@bjester bjester changed the title #3158: Issue fixed , check order for validation changed. Fix for editing an exercise after adding a thumbnail Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot finish editing an exercise if I've added a thumbnail
3 participants