Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip out any remaining HTML as Kolibri will only render pure markdown. #3397

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

rtibbles
Copy link
Member

Summary

Description of the change(s) you made

  • Strips out any remaining HTML tags after we have done any other relevant conversion.

Manual verification steps performed

The issue was a little hard to reproduce without Microsoft Word and Windows on hand, but the simplest thing to do was to inspect the HTML of the editor area, edit it as HTML and then paste this into the HTML:

Karol <span style="letter-spacing: 0.03em;" data-tomark-pass="">__________________ talks in class</span>

then confirm that this gets saved without the HTML embedded.

Fixes #3345

Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @rtibbles, it's looking good to me.

@rtibbles rtibbles merged commit aefca4b into learningequality:unstable Jun 1, 2022
@rtibbles rtibbles deleted the no_html branch June 1, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy pasting rich content into an assessment rich text editor does not strip out HTML tags
2 participants