Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set complete marking on nodes created by ricecooker #3410

Merged
merged 3 commits into from
Jul 28, 2022

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jun 9, 2022

Summary

Description of the change(s) you made

  • Creates a mark_complete method for ContentNode
  • Includes all criteria from the mark_incomplete management command
  • Applies at the end of node creation
  • Creates tests for the various conditions

References

Fixes #2806

Comments

Not entirely sure how we should audit this - we definitely had some issues with the mark_incomplete management command when we ran it on historic data - but I don't have a strong sense of how much of that was affecting cheffed channels.

@rtibbles rtibbles requested a review from bjester June 9, 2022 19:38
@rtibbles rtibbles marked this pull request as ready for review June 9, 2022 19:38
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking, but left a suggestion and an idea for auditing.

contentcuration/contentcuration/views/internal.py Outdated Show resolved Hide resolved
rtibbles added 2 commits July 22, 2022 14:29
Report incomplete chef nodes on sentry, but do not mark as incomplete yet.
@rtibbles rtibbles merged commit 412f26f into learningequality:unstable Jul 28, 2022
@rtibbles rtibbles deleted the node_complete branch July 28, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nodes from chef runs should be properly marked as complete/incomplete
2 participants