Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default upload duration being shown in raw seconds #3470

Merged

Conversation

vkWeb
Copy link
Member

@vkWeb vkWeb commented Jul 30, 2022

Summary

This PR fixes the default upload duration being shown in raw seconds. Now, we show the duration in HH:MM:SS format.

Screenshots (if applicable)

Before:
image

After:
image


Reviewer guidance

  1. Sign up with [email protected].
  2. Start editing a sample video file.
  3. Observe the time shown beside "Completion -> Duration" field when "Exact time to complete" is selected.

References

Closes #3465.


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@vkWeb vkWeb requested a review from rtibbles July 31, 2022 21:22
@vkWeb
Copy link
Member Author

vkWeb commented Jul 31, 2022

@rtibbles the above mentioned issue on PR description is fixed.

Btw, there's a bug that I observed while I was fixing this issue. On uploading a new file when there's a already uploaded file, the ActivityDuration component doesn't get updated. So, the old duration is still visible.

If we can make ActivityDuration react whenever a new file is uploaded we can fix it I think?

@rtibbles
Copy link
Member

rtibbles commented Aug 1, 2022

Ah, that's a good catch - can you file a follow up issue for that case?

@@ -167,6 +167,20 @@
handleInput(value) {
this.$emit('input', this.convertToSeconds(value));
},
convertToHHMMSS(totalSeconds) {
if (totalSeconds !== null && Number.isInteger(totalSeconds)) {
const hours = Math.floor(totalSeconds / 3600)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method will give the same result and seems a little simpler: https://stackoverflow.com/a/25279399

Copy link
Member Author

@vkWeb vkWeb Aug 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That implementation breaks when input seconds are greater than or equal to 86400 seconds.

On 86400 seconds, it outputs 00:00:00. The expected output should be 24:00:00. Date objects are relative to specific parameters like timezone, etc. And our use case is absolute in nature. So, IMO the current implementation feels more robust to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An excellent point!

@vkWeb
Copy link
Member Author

vkWeb commented Aug 2, 2022

An issue for the outdated completion criteria duration: #3472.

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it does the trick!

@rtibbles rtibbles merged commit 56117a3 into learningequality:unstable Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default upload duration value for video and audio files is shown as raw number of seconds
2 participants