Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new models for full text search and migration commands #3651

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

vkWeb
Copy link
Member

@vkWeb vkWeb commented Sep 16, 2022

Summary

This PR brings in database updates required for Studio's full text search API code to work.


Reviewer guidance

Below operations should be performed to make sure the db updates are working as expected, I've carried out all & they are working all as expected:

  • make migrate creates the new fts tables and indexes concurrently. Watch the SQL output. It should add index concurrently.
  • Create a channel, create few nodes and delete some to replicate real world channels and then publish it. Then run make set-tsvectors. You should find your channel and its contentnodes records in search_contentnodefulltextsearch and search_channelfulltextsearch tables.

That's it!

References

Refers #3186
Refers #2934
Refers #3399


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
@vkWeb vkWeb requested review from bjester and rtibbles September 16, 2022 17:03
@bjester bjester changed the title Studio fts database updates Add new models for full text search and migration commands Sep 16, 2022
@bjester bjester merged commit 54f7790 into learningequality:unstable Sep 16, 2022
@vkWeb vkWeb deleted the fts_db_updates branch September 16, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants