-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropdown consolidation, layout fixes, and RTL updates #3679
Dropdown consolidation, layout fixes, and RTL updates #3679
Conversation
cf4a00c
to
e135891
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bjester this looks great!!
-
The dropdowns in all places you list seem to be working as expected 🎉 I checked, and code review looks good.
✅ Edit modal
✅ Editing channel details
✅ Signing up for a new account
✅ Catalog search
✅ Import search -
The alignment of the checkboxes is also fixed. ✅
-
Needs to be fixed: I don't see the thumbnail changes on RTL that you have a screenshot of 🤔 (I double checked that I wasn't running devserver hot).
- Not blocking, but would be great to add. The last thing is I found two more places where the new dropdown wrapper could be added:
Under administration/user, click on a user listed, and scroll down to the storage space
@marcellamaki Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @bjester
Summary
Background
absolute
positioning instead of thefixed
positioningDescription of the change(s) you made
attach
attribute to Vuetify selects, autocompletes, and menusManual verification steps performed
Screenshots (if applicable)
Does this introduce any tech-debt items?
<DropdownWrapper>
for handling viewport resizesReviewer guidance
How can a reviewer test these changes?
Much of the diff comes from wrapping templates with
<DropdownWrapper>
References
Fixes #3689
Fixes #3678
Fixes #3666
Comments
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)