Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issues with editing and browsing newly added topics #3707

Merged
merged 2 commits into from
Sep 30, 2022

Conversation

bjester
Copy link
Member

@bjester bjester commented Sep 30, 2022

Summary

Description of the change(s) you made

  • @ozer550 and cohacked on this
  • Prevents making HEAD requests to the backend if the requested resource may not have been created on the backend yet, preventing 'Page not found' when opening newly created folders
  • Fixes issue opening non-existent tabs in the edit modal, causing a blank screen when editing details

Manual verification steps performed

For #3699

  1. Stop celery
  2. Open a channel for editing
  3. Create a new folder
  4. Open the folder
  5. Verify you don't see 'Page not found'

For #3681

  1. Click to edit the channel's details
  2. Click the Sharing tab
  3. Close the modal
  4. Click on the kebab menu for a folder
  5. Click to create a new folder
  6. Verify the edit modal details fields aren't missing

References

Fixes #3699
Fixes #3681

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester requested review from ozer550 and rtibbles September 30, 2022 17:44
@bjester bjester marked this pull request as ready for review September 30, 2022 17:44
@rtibbles
Copy link
Member

When testing the fix for #3699 I can confirm that I no longer see 'page not found', but instead I get a 400 on the request to get child nodes, and it stays in a permanent loading state:
image

I think maybe just catching the 400 here might be needed?

Fix for #3681 confirmed.

@bjester
Copy link
Member Author

bjester commented Sep 30, 2022

@rtibbles Ah we had commented out the fetchCollection in the where method during our testing, but restored it during commit. That's where the 400 is coming from, so a further change there is needed. Working on it

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense, manual testing checks out!

@pcenov
Copy link
Member

pcenov commented Oct 3, 2022

Excellent, both issues are fixed now!

@bjester bjester mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants