-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows users to change language when not signed-in. thus, implementing proper language redirection as in Kolibri #3721
Allows users to change language when not signed-in. thus, implementing proper language redirection as in Kolibri #3721
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my testing, when I'm on the sign-in page and I change the language, the page refreshes again after reloading. It seems related to the service worker, and I think it must be the pwa/manifest.json
causing it because it loads the language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me-- one comment about adding/updating the doc string
@@ -353,42 +352,54 @@ def set_language(request): | |||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add/replace the doc string here noting where this code came from and what you changed?
Summary
The Following Pr adds the functionality to the change language while viewing the public resources page or any other pages when not being signed in. It also implements proper redirection according to session and cookie data as in Kolibri.
closes #3150
Description of the change(s) you made
Manual verification steps performed
Screenshots (if applicable)
Before:
After:
Does this introduce any tech-debt items?
Reviewer guidance
How can a reviewer test these changes?
References
The set_language function is refactored from here
Contributor's Checklist
PR process:
Testing:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)