Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do defaulting better to allow falsey values. #3801

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Nov 7, 2022

Summary

Description of the change(s) you made

  • Uses lodash get to get values from extra_fields rather than direct property access, to ensure that falsy values are not overridden by the default value.

Manual verification steps performed

  1. Unchecked 'randomize' on an exercise
  2. Waited for save. Reopened edit modal.
  3. Confirmed it remained unchecked.

Screenshots (if applicable)

Screencast.from.11-07-2022.07.42.38.AM.webm.mp4

Fixes #3800

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pcenov
Copy link
Member

pcenov commented Nov 8, 2022

Hi @rtibbles I confirm that now the checkbox remains unchecked however this is not reflected in Kolibri (latest 0.15.9 build) where the questions are still being randomized. That could be a Kolibri issue - let me know if so and I'll open an issue there.

@rtibbles
Copy link
Member Author

rtibbles commented Nov 8, 2022

Hrm, it's possible there's a further issue with the publishing. I'll see if I can reproduce.

@rtibbles rtibbles deleted the default_properly branch November 8, 2022 21:26
@rtibbles
Copy link
Member Author

rtibbles commented Nov 8, 2022

I am unable to replicate this on hotfixes. The exported channel database has the properly set randomize flag set to false when unchecked, and when rendering in Kolibri, regardless of the user I access it as, it's not being randomized.

@rtibbles
Copy link
Member Author

rtibbles commented Nov 9, 2022

@radinamatic and I think we isolated what was happening in Kolibri, and have a fix here: learningequality/kolibri#9819 (comment) it didn't seem to be an issue with randomization as such, but rather only alternate questions being displayed.

@bjester bjester mentioned this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants