-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the image remove option work #3837
Make the image remove option work #3837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still noticing some differences with this method vs with the cursor next to the image and inputting backspace. It seems that this still leaves an image wrapper, and that becomes a pesty blank space that will only be removed if you explicitly select it with the cursor and input backspace, or close and reopen the exercise.
Oh, interesting - I guess the existing destroy wasn't doing enough. Will look in more detail! |
So, I've managed to make the span delete itself, but the |
trying to do prohibited direct prop modification on component. Lint.
OK, this should all be working as intended now. I've updated the PR description with the additional fixes and an updated screencast. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@rtibbles I was able to identify the following issues:
2022-12-06_15-10-43.mp4 |
For this, how was this image added? Was it pasted into the text box, added using the 'add image' button?
Interesting, this must be an issue with the data not being persisted properly. |
Summary
Description of the change(s) you made
Manual verification steps performed
Screenshots (if applicable)
Screencast.from.11-22-2022.02.28.17.PM.webm
Screencast.from.11-23-2022.02.31.18.PM.webm
References
Fixes #3817