Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabled double submit while creating a channel #3843

Merged
merged 2 commits into from
Dec 5, 2022
Merged

disabled double submit while creating a channel #3843

merged 2 commits into from
Dec 5, 2022

Conversation

AllanOXDi
Copy link
Member

@AllanOXDi AllanOXDi commented Nov 25, 2022

Summary

This PR fixes the double submit error while creating a new channel.
Ref #3833

Manual verification steps performed

Step 1: Try to create a new channel from studio, and observe what is happening on clicking create button.
Step 2: You may also try on a slow network connectivity

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

self.perform_create(serializer)

except IntegrityError as e:
return Response({"error": str(e)}, status=409)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's worth doing, but if the endpoint returns this 409 status code, then perhaps the frontend can redirect to the channel page like it does with the normal 201 response?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think our main objective while implementing this was to try and throw a more meaningful error when creating a channel that the Id already exists.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay! I was simply thinking about whether the change was as meaningful to the end-user as it is to us, since it would silence error reports on our end.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree! But again, do we need a redirect when double creation happens? Or we could try and find a way of letting the user know if double creation happened.

Copy link
Member

@bjester bjester Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's very unlikely a user encounters this scenario submitting the form. But if they somehow did encounter it, or perhaps even a gateway timeout 502 error, I don't think the frontend would give the user notice one of those errors occurred, meaning the submit button would be forever disabled without any indication to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants