-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate agreement opt-ins during account creation #3895
Consolidate agreement opt-ins during account creation #3895
Conversation
contentcuration/contentcuration/frontend/accounts/pages/Create.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the contactMessage
string back to its original form-- see my comment about the reasons why. Also, it appears some JS tests for account creation are failing, and they likely need updated to handle only one checkbox. You can run it with:
yarn run test-jest contentcuration/contentcuration/frontend/accounts/pages/__tests__/create.spec.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, Allan!
Summary
This PR aims to consolidate the sign-up experience for users in Studio. Currently, a first-time user has to agree to two mandatory opt-ins at sign-up Terms of Service and privacy policy these processes are separated and require users to complete multiple steps to fully sign up. Consolidating these processes into a single, cohesive flow will make it as simple and straightforward as possible for users to opt-in or sign up in Studio.
closes #3834
Manual verification steps performed
Screenshots (if applicable)
Before
After:
figma
https://www.figma.com/file/1tQQ0Sw1yDjzO66hyjLVPM?node-id=556:4666#323944643
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)