Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate agreement opt-ins during account creation #3895

Merged
merged 8 commits into from
Jan 27, 2023
Merged

Consolidate agreement opt-ins during account creation #3895

merged 8 commits into from
Jan 27, 2023

Conversation

AllanOXDi
Copy link
Member

@AllanOXDi AllanOXDi commented Dec 21, 2022

Summary

This PR aims to consolidate the sign-up experience for users in Studio. Currently, a first-time user has to agree to two mandatory opt-ins at sign-up Terms of Service and privacy policy these processes are separated and require users to complete multiple steps to fully sign up. Consolidating these processes into a single, cohesive flow will make it as simple and straightforward as possible for users to opt-in or sign up in Studio.
closes #3834

Manual verification steps performed

  1. Navigate to sign in page > create account

Screenshots (if applicable)

Before
Screenshot 2022-12-30 at 17 10 42
After:
Screenshot 2022-12-30 at 17 09 36

figma

https://www.figma.com/file/1tQQ0Sw1yDjzO66hyjLVPM?node-id=556:4666#323944643

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@AllanOXDi AllanOXDi marked this pull request as ready for review December 30, 2022 16:40
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the contactMessage string back to its original form-- see my comment about the reasons why. Also, it appears some JS tests for account creation are failing, and they likely need updated to handle only one checkbox. You can run it with:

yarn run test-jest contentcuration/contentcuration/frontend/accounts/pages/__tests__/create.spec.js

@AllanOXDi AllanOXDi requested a review from bjester January 6, 2023 21:31
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Allan!

@bjester bjester changed the title refactored signup page Consolidate agreement opt-ins during account creation Jan 27, 2023
@bjester bjester merged commit b448703 into learningequality:unstable Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate opt-ins in Studio sign-up
2 participants