Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates nested folder order in breadcrumb #4003

Merged

Conversation

LianaHarris360
Copy link
Member

@LianaHarris360 LianaHarris360 commented Mar 24, 2023

Summary

Description of the change(s) you made

Updates order of nested folders within breadcrumbs.

Manual verification steps performed

  1. Create or update channel with multiple nested folders.
  2. Confirm that the breadcrumb reflects the correct sequence of the nested folders.

Screenshots (if applicable)

Before

BreadcrumbsBefore

After

BreadcrumbsAfter

BreadcrumbsAfter2

References

Closes #3842

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@LianaHarris360 LianaHarris360 marked this pull request as ready for review March 24, 2023 15:43
@@ -341,7 +341,7 @@
return {
id: ancestor.id,
to: this.treeLink({ nodeId: ancestor.id }),
title: ancestor.title,
title: ancestor.parent ? ancestor.title : this.currentChannel.name,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is a really clever solution! looks good to me!

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @LianaHarris360. This should be merged subject to manual QA checks. cc @radinamatic

@radinamatic
Copy link
Member

QA team will proceed with testing as soon as the PR is merged in the unstable branch 👍🏽
cc @pcenov

@LianaHarris360 LianaHarris360 merged commit 0c109db into learningequality:unstable Mar 28, 2023
@pcenov
Copy link
Member

pcenov commented Mar 29, 2023

Hi @LianaHarris360 and @radinamatic, I was able to identify the following issues which I have reported separately: #4006 and #4007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hotfixes - Breadcrumbs hickups
5 participants