Basic integration of updated kolibri-tools #4045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I have some linting updates to make here. |
Mostly setting lets to const when appropriate. Ignore variables from vuetify.
bjester
changed the title
nucleogenesis
approved these changes
May 4, 2023
| @@ -26,15 +26,15 @@ module.exports = (env = {}) => { | |||
| const hot = env.hot; | |||
| const base = baseConfig({ mode: dev ? 'development' : 'production', hot, cache: dev }); | |||
|
|
|||
| if (String(base.module.rules[2].test) !== String(/\.css$/)) { | |||
| if (String(base.module.rules[1].test) !== String(/\.css$/)) { | |||
There was a problem hiding this comment.
Just curious what changed that made this value need to change?
There was a problem hiding this comment.
This commit in Kolibri changed the order of the rules in the basic webpack config: learningequality/kolibri@5ba4074
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Manual verification steps performed
Ran
make i18n-extractRan
yarn run devserver-hotRan
yarn run buildAll seemed to do what I expected.