-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed IconButton to KRouterLink #4374
Changed IconButton to KRouterLink #4374
Conversation
contentcuration/contentcuration/frontend/channelEdit/pages/StagingTreePage/index.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of changes in the StagingTreePage/index.vue
updates here.
Overall this is the exact right direction! Thanks so much @BabyElias for this submission!
contentcuration/contentcuration/frontend/channelEdit/pages/StagingTreePage/index.vue
Outdated
Show resolved
Hide resolved
Thank you so much for your feedback! |
contentcuration/contentcuration/frontend/channelEdit/pages/StagingTreePage/index.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BabyElias I've tested this locally and all looks good! Feel free to tag me for review on any follow-up issues you create along these lines.
Summary
Updated IconButton to use KComponents (KRouterLink, KIcon & KIconButton) instead.
Description of the change(s) you made
learningequality/kolibri-design-system#219
Screenshots (if applicable)
The icons that have been changed
Reviewer guidance
How can a reviewer test these changes?
This is just a trial PR to confirm that I am headed in the right direction or not.
If this pull request is accepted and merged, I plan to submit additional pull requests addressing other issue with more extensive changes. The current pull request contains only minor modifications related to that issue.
Contributor's Checklist
Testing:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)