-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick edit modal to edit Source #4424
Quick edit modal to edit Source #4424
Conversation
close() { | ||
this.$emit('close'); | ||
}, | ||
validate() {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the validate
meant to do anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! @akolson. Yes, It was meant to validate the attribution 😓 I have updated the code! Could you please review it again? :)
3da5e0b
to
d86a7d6
Compare
d86a7d6
to
159669a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AlexVelezLl. Implementation looks correct to me and understandable. Thanks
823d16b
into
learningequality:studio-usability-enhancements
Summary
Description of the change(s) you made
Add a quick edit modal to edit resources attribution/source.
Screenshots (if applicable)
Compartir.pantalla.-.2024-02-05.12_37_55.mp4
Reviewer guidance
How can a reviewer test these changes?
References
Closes #3419
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)