Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick edit modal to edit Source #4424

Conversation

AlexVelezLl
Copy link
Member

@AlexVelezLl AlexVelezLl commented Feb 1, 2024

Summary

Description of the change(s) you made

Add a quick edit modal to edit resources attribution/source.

Screenshots (if applicable)

Compartir.pantalla.-.2024-02-05.12_37_55.mp4

Reviewer guidance

How can a reviewer test these changes?

  1. Go to update a channel content
  2. Click on the "Edit source" option on the content node menu of a resource (non-folder).
  3. Or select multiple resources (non-folders) and select "Edit Source" from bulk toolbar.

References

Closes #3419


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • [ x If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@AlexVelezLl AlexVelezLl requested a review from akolson February 1, 2024 13:55
close() {
this.$emit('close');
},
validate() {},
Copy link
Member

@akolson akolson Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the validate meant to do anything?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! @akolson. Yes, It was meant to validate the attribution 😓 I have updated the code! Could you please review it again? :)

@AlexVelezLl AlexVelezLl force-pushed the quick-edit-modal-attribution branch from 3da5e0b to d86a7d6 Compare February 14, 2024 21:45
@AlexVelezLl AlexVelezLl force-pushed the quick-edit-modal-attribution branch from d86a7d6 to 159669a Compare February 14, 2024 21:58
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AlexVelezLl. Implementation looks correct to me and understandable. Thanks

@AlexVelezLl AlexVelezLl merged commit 823d16b into learningequality:studio-usability-enhancements Feb 15, 2024
13 checks passed
@AlexVelezLl AlexVelezLl deleted the quick-edit-modal-attribution branch February 15, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants