Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement feedback models #4490

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

ozer550
Copy link
Member

@ozer550 ozer550 commented Mar 27, 2024

Summary

Implements feedback models to support Flagging, RecommendationsEvent and RecommendationdInteraction events.

Description of the change(s) you made

  • Added decided hierarchy of models using abstract models.
  • Unit tests for creation of models.

References

closes #4477

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

@ozer550 ozer550 requested a review from bjester March 27, 2024 11:57
@ozer550 ozer550 force-pushed the implement-feedback-models branch from 35e02d6 to 7a3ed60 Compare March 27, 2024 15:48
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test performance can likely be increased, but otherwise looks good

contentcuration/contentcuration/models.py Outdated Show resolved Hide resolved
contentcuration/contentcuration/models.py Outdated Show resolved Hide resolved
contentcuration/contentcuration/tests/test_models.py Outdated Show resolved Hide resolved
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good clean work! Nice job

@bjester bjester merged commit 5137b46 into learningequality:unstable Apr 15, 2024
13 checks passed
@akolson akolson mentioned this pull request Aug 13, 2024
@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Flag Feedback and Recommendation Feedback Models
2 participants