Resolves KCheckbox issues selecting all items in trash modal #4526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is related to #4510 |
bjester
changed the title
AlexVelezLl
requested changes
May 17, 2024
There was a problem hiding this comment.
Hi @joeysantia 👋 Apologies for the delay in following up on this PR. The change seems to be correct, I just left a note about a specific case we can fix, and after that it should be good to go 👐.
| @@ -23,10 +23,10 @@ | |||
| <VLayout v-if="props.header.selectAll" row align-center> | |||
| <VFlex shrink> | |||
| <Checkbox | |||
| :value="Boolean(selected.length)" | |||
| :value="selected.length === items.length" | |||
There was a problem hiding this comment.
To explicitly pass the boolean checkbox value, we need to use the prop inputValue instead. Without this, we have this issue: when all items are selected, the checkbox doesnt appear as selected.
Compartir.pantalla.-.2024-05-17.07_37_58.mp4
There was a problem hiding this comment.
Ah I see ! I'll make that change
AlexVelezLl
approved these changes
May 29, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Changed the
@changeproperty in TrashModal.vue to@inputand changed the value of the checkbox to reflect whether all items are selected (e.g. value is falsy Boolean if not all items are selected). Edited the TrashModal tests to reflect this implementationManual verification steps performed
@changeto@input@inputpropertyReviewer guidance
How can a reviewer test these changes?
Contributor's Checklist
Testing:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)