Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incomplete resource importable #4618

Conversation

AlexVelezLl
Copy link
Member

Summary

Description of the change(s) you made

Avoid listing incomplete resources in "import from channels" view.

Manual verification steps performed

  1. Tried loading incomplete resources that were already loaded in indexedDB.
  2. Tried loading incomplete resources that havent been loaded before.
  3. Verfied that the rest of valid resources/folders appear in the search.

Screenshots (if applicable)

Given this incomplete resource:
image

Before:

image

After:

image

Does this introduce any tech-debt items?


Reviewer guidance

How can a reviewer test these changes?

  1. Create incomplete resources in a given channel.
  2. Publish the channel
  3. Go to another channel and click on Add > Import from channels
  4. Look for the incomplete resource, it should not appear.

References

Closes #4088


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense - I have not manually tested.

I keep wondering to myself, whether we should be using the indexedDB layer for this kind of listing, but it does perhaps still provide some value for high latency/unreliable connections.

@rtibbles rtibbles self-assigned this Jul 25, 2024
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look correct to me! Also, Manual QA checks out! Thanks @AlexVelezLl!

image

@AlexVelezLl
Copy link
Member Author

Thank you @akolson!!

@AlexVelezLl AlexVelezLl merged commit c0e740e into learningequality:unstable Jul 30, 2024
13 checks passed
@AlexVelezLl AlexVelezLl deleted the fix-incomplete-resources-importable branch July 30, 2024 18:53
@akolson akolson mentioned this pull request Aug 13, 2024
@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete resources importable from channel import
3 participants