Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the undo selection issue in the snackbar after resource deletion #4667

Merged

Conversation

LianaHarris360
Copy link
Member

Summary

Description of the change(s) you made

This pull request fixes the issue with the undo button's selection functionality not working correctly within the snackbar following the removal or deletion of a resource in ContentNodeOptions.vue.

The function removeNode is now called with an explicit argument, onClick: () => this.removeNode([this.nodeId]). This fixes potential issues by removing the reliance on direct access to this.nodeId within the function, which helps in cases where the function's context (this) may be ambiguous.

Manual verification steps performed

  1. Removed a resource from a channel using the three-dot menu and selecting 'Remove'
  2. Selected the Undo button in the snackbar.

Screenshots (if applicable)

Before:

undobefore.mov

After:

undoAfter.mov

Reviewer guidance

How can a reviewer test these changes?

  1. Remove a resource from a channel by pressing the three-dot menu and selecting 'Remove'
  2. Select the Undo button in the snackbar.
  3. Verify resource is restored to its original location

References

Fixes #4641


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me and manual QA checks out!.
However, I picked up a bug on the terms of service button not working on click, so I had to disable the modals to test the actual bug. Adding a little blocker just in case.
Screenshot 2024-08-22 at 23 38 01

@akolson
Copy link
Member

akolson commented Aug 22, 2024

The issue above is present in unstable too and a follow-up issue will be filed for its resolution

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@rtibbles rtibbles merged commit a9bd3b9 into learningequality:unstable Aug 23, 2024
13 checks passed
@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to 'Undo' after resource removal/deletion
3 participants