Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy modals send policy to accept when accept is emitted #4670

Conversation

nucleogenesis
Copy link
Member

@nucleogenesis nucleogenesis commented Aug 22, 2024

Summary

Description of the change(s) you made

Send the policy when emitting the accept event from Policy modals so that it works properly.

Reviewer guidance

How can a reviewer test these changes?

If you have already accepted the policies, you can use the following process to reset your user's acceptance. Be wary that the code will only update the first created user so be sure to verify that you're updating the user you want.

./contentcuration/manage.py shell to get a shell open

from contentcuration.models import User
me = User.objects.first()
me.policies = {}
me.save()

Now you should be able to accept all of the policies that need acceptance.

Are there any risky areas that deserve extra testing?

References

Fixes #4669

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@nucleogenesis nucleogenesis requested a review from akolson August 22, 2024 22:27
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! Manual QA checks out! Thanks @nucleogenesis

@rtibbles rtibbles merged commit 193c1c5 into learningequality:unstable Aug 23, 2024
13 checks passed
@akolson akolson mentioned this pull request Aug 24, 2024
@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continue button on the Terms of servivce modal is not working
3 participants