Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include requirements.txt #128

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Conversation

thewchan
Copy link
Contributor

Currently requirements.txt is not included in the sdist, which causes setup.py to fail during building downstream in conda forge

@lebrice
Copy link
Owner

lebrice commented Apr 27, 2022

Hey there @thewchan, thanks for this PR!

which causes setup.py to fail during building downstream in conda forge

Interesting! I'd be curious, would you mind elaborating a little bit?
Apologies for the question, since I don't know much about Conda packaging, but are you building simple-parsing through Conda somehow? Or just pip-installing it inside a conda environment?

@lebrice lebrice merged commit 2cc9093 into lebrice:master Apr 27, 2022
@thewchan
Copy link
Contributor Author

@lebrice Sure thing! I'm maintaining simple parsing on the conda-forge repo; it basically fetch the sdist from pypi, and run setup.py to build the package, because of that, it needs all the required file in the sdist bundle. E.g., setup.py reads readme.md in one of the steps, which works fine since readme.md is present in the sdist file bundle on PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants