Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build ubuntu qa #32

Merged
merged 26 commits into from
Jan 5, 2025
Merged

Build ubuntu qa #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
9a5ce6f
build:ubuntu - qa.Dockerfile node stable version
lehungio Jan 4, 2025
a584a51
fix:build-scala-mantic - failed to resolve system dependencies
lehungio Jan 4, 2025
e07d3a0
fix:build - node version
lehungio Jan 4, 2025
579bb81
fix:ci - run build & test
lehungio Jan 4, 2025
f120897
build:ghcr - push to container registry
lehungio Jan 4, 2025
e37720c
build:ci - ghcr
lehungio Jan 4, 2025
b6b7885
build:ubuntu-latest - ghcr
lecaoquochung Jan 4, 2025
6a6dc30
build:ubuntu-latest - test build
lecaoquochung Jan 4, 2025
ced84c8
build:ubuntu-latest - docker tag
lecaoquochung Jan 4, 2025
90e2899
build:ubuntu-latest - ghcr
lecaoquochung Jan 4, 2025
3ab5184
build:ubuntu-latest - tag name
lecaoquochung Jan 4, 2025
2e16e9e
build:ubuntu-latest - tag
lecaoquochung Jan 4, 2025
08b1142
build:tweak
lecaoquochung Jan 4, 2025
0339a99
build:tweak
lecaoquochung Jan 4, 2025
501f15a
build:tweak
lecaoquochung Jan 4, 2025
8084ea4
build:tweak
lecaoquochung Jan 4, 2025
6025747
build:tweak
lecaoquochung Jan 4, 2025
f4bbdb9
build:tweak
lecaoquochung Jan 4, 2025
eb04fd5
build:tweak
lecaoquochung Jan 4, 2025
b071478
build:tweak
lecaoquochung Jan 4, 2025
ad1c8db
build:tweak
lecaoquochung Jan 4, 2025
23c40c9
build:tweak
lecaoquochung Jan 4, 2025
e685a08
github:ci - tag name
lehungio Jan 5, 2025
35e6601
github:ci - refactoring
lehungio Jan 5, 2025
5cc5953
github:action - job, workflow config
lehungio Jan 5, 2025
0dd34e1
tweak
lehungio Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/automation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,13 @@ jobs:
- uses: actions/checkout@v4
- name: scala-bionic
run: docker build . --file ./scala/build/bionic.Dockerfile --tag "scala-bionic:$(date +%s)"
build-scala-mantic:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: scala-mantic
run: docker build . --file ./scala/build/Dockerfile.mantic --tag "scala-mantic:$(date +%s)"
# Deprecated - v2024.4.1
# build-scala-mantic:
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v4
# - name: scala-mantic
# run: docker build . --file ./scala/build/mantic.Dockerfile --tag "scala-mantic:$(date +%s)"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Remove trailing space.
There's trailing whitespace at line 61. Fix to align with linting rules.

-  #     run: docker build . --file ./scala/build/mantic.Dockerfile --tag "scala-mantic:$(date +%s)" 
+  #     run: docker build . --file ./scala/build/mantic.Dockerfile --tag "scala-mantic:$(date +%s)"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# run: docker build . --file ./scala/build/mantic.Dockerfile --tag "scala-mantic:$(date +%s)"
# run: docker build . --file ./scala/build/mantic.Dockerfile --tag "scala-mantic:$(date +%s)"
🧰 Tools
🪛 yamllint (1.35.1)

[error] 61-61: trailing spaces

(trailing-spaces)

build-scala-maintenance:
runs-on: ubuntu-latest
steps:
Expand Down
Loading
Loading