Skip to content

Commit

Permalink
The superclass property idea did not quite work out. Reverted.
Browse files Browse the repository at this point in the history
  • Loading branch information
Sergei Kozlov committed Nov 17, 2010
1 parent cc98040 commit 29cccb4
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
1 change: 0 additions & 1 deletion CHANGELOG.rdoc
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
* An endpoint can now "call" JavaScript functions that accept multiple parameters, by specifying an array, e.g.:
{:some_js_function => [arg1, arg2]}
* New API: +js_mixin+ method (see RDocs)
* JavaScript instance of a component now has the property "superclass", which refers to the prototype of the parent class. Handy when calling the super methods.

* bug fix
* The "componentload" event now gets fired after a component is dynamically loaded. The handler receives the instance of the loaded component.
Expand Down
2 changes: 1 addition & 1 deletion lib/netzke/javascript.rb
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def js_properties(hsh = nil)

# JS properties and methods merged together
def js_extend_properties
@_js_extend_properties ||= js_properties.merge(js_methods).merge(:superclass => "#{superclass.js_base_class}.prototype".l)
@js_extend_properties ||= js_properties.merge(js_methods)
end

# Mixes the JavaScript object defined in <component_file_name>/javascripts/<name>.js as public properties for the generated class
Expand Down
3 changes: 2 additions & 1 deletion netzke-core.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Gem::Specification.new do |s|

s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
s.authors = ["Sergei Kozlov"]
s.date = %q{2010-11-16}
s.date = %q{2010-11-17}
s.description = %q{Allows building ExtJS/Rails reusable code in a DRY way}
s.email = %q{[email protected]}
s.extra_rdoc_files = [
Expand Down Expand Up @@ -207,6 +207,7 @@ Gem::Specification.new do |s|
"test/rails_app/app/components/scoped_components/some_scoped_component.rb",
"test/rails_app/app/components/server_caller.rb",
"test/rails_app/app/components/simple_component.rb",
"test/rails_app/app/components/simple_panel.rb",
"test/rails_app/app/components/simple_tab_panel.rb",
"test/rails_app/app/components/simple_window.rb",
"test/rails_app/app/components/some_composite.rb",
Expand Down

0 comments on commit 29cccb4

Please sign in to comment.