This repository has been archived by the owner on Sep 23, 2023. It is now read-only.
E3 agg commitment #647
Merged
E3 agg commitment #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
state/history.go
Outdated
| files *btree.BTreeG[*filesItem] | ||
| compressVals bool | ||
| files *btree.BTreeG[*filesItem] | ||
| valueMergeFn func(prev, last []byte) ([]byte, error) |
There was a problem hiding this comment.
Perhaps this valueMergeFn should belong to Domain instead? I did not see how it is used in History
recsplit/eliasfano32/elias_fano.go
Outdated
| p := (*[maxDataSize / 8]uint64)(unsafe.Pointer(&r[16])) | ||
| ef.data = p[:] | ||
|
|
||
| ef.data = make([]uint64, len(r[16:])/8) |
There was a problem hiding this comment.
This needs to be undone, because the idea is to use memory-mapped files and not allocate it on the heap
There was a problem hiding this comment.
we discussed that already, using unsafe pointer p leads to use-after-close in indexes
awskii
force-pushed
the
e3-agg-commitment
branch
from
f37962f to
916bf60
Compare
|
Fuzz test requires to be revisited, working on it, everything else looks working. |
awskii
force-pushed
the
e3-agg-commitment
branch
from
ba8d85c to
6a9314f
Compare
awskii
force-pushed
the
e3-agg-commitment
branch
from
21aea80 to
61d7e77
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.