Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade benchmark to Chart.js 3.0.0-alpha.2 #277

Merged
merged 1 commit into from
Aug 2, 2020

Conversation

benmccann
Copy link
Contributor

This is about 25% faster on my machine

@leeoniya
Copy link
Owner

thanks, about 13% faster here, ~315ms -> ~275ms. i'll merge this when i have some more time to do a full bench run.

@leeoniya
Copy link
Owner

@benmccann is there a way to improve the cursor performance, at least outside the plotting area where the legend toggles are?

when i do these benchmarks i notice a ton of time is being spent on me simply moving the cursor to the legend to toggle it. even a short distance whch comes in from the edge and does not cross the plotting area is crazy expensive.

on the one hand i want to [tediously] exclude this to have apples to apples. on the other hand this slowdown will affect all practical use cases IRL, so i dont feel like you guys deserve the pass here.

@benmccann
Copy link
Contributor Author

Thanks for the suggestion! I've added that to the suggested list of improvements for v3. I know our tooltip performance could be better, but I've never actually seen a user-visible impact from it, so have never prioritized it. Plus I'm trying to spend less time of the charting stuff, so doubt that I'll get around to implementing it, but perhaps someone else will pick it up.

@leeoniya
Copy link
Owner

okay, thanks.

i guess i'll just try to come in from the edge and also include any intra-legend mousemoves as part of the toggle 6x metric. even this would be quite generous since most toggle cases in real life will have multi-factor more mousemoves before reaching the legend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants