Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Options Flow for Gateway and Sub Devices #30

Conversation

alexualbu
Copy link

@alexualbu alexualbu commented Jan 16, 2023

Draft PR to fix Options flow for Gateways and Sub-devices. First contribution so please bear with me & have a first look @leeyuentuen . Should I add and issue first?

Issues fixed:

  • options flow does not work for gateways due to missing entities (#28)
  • init step of options flow for sub-devices required both host and local key + not saving parent_gateway which caused issues with the devices upon saving

@leeyuentuen
Copy link
Owner

on first view it look ok.
if you want i can merge them and put them in beta to let other people test them

@alexualbu alexualbu marked this pull request as ready for review January 16, 2023 13:40
@alexualbu
Copy link
Author

thanks, @leeyuentuen!
So are you saying I should create another beta branch ?

@leeyuentuen leeyuentuen changed the base branch from master to 3.6.4 January 16, 2023 13:44
@leeyuentuen leeyuentuen merged commit 1f09ec4 into leeyuentuen:3.6.4 Jan 16, 2023
@leeyuentuen
Copy link
Owner

leeyuentuen commented Jan 16, 2023

i've created a beta release on it.
https://github.com/leeyuentuen/localtuya/releases/tag/3.6.4-beta.1

@alexualbu alexualbu deleted the fix_sub_device_and_gateway_options_flow branch January 16, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants