-
Notifications
You must be signed in to change notification settings - Fork 43
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Return error on stream error for retry (#565)
`handleEvent` was handling the an `error` type by printing something, but then not continuing to raise the error. This means that in a stream error, particuarly of type INTERNAL_ERROR, the backoff/retry mechanism never took place as the return was `nil` and the agent just stopped. The problem is particularly relevant with Google Load Balancers and their handling of http2/websocket long lived connections: golang/go#51323 --------- Co-authored-by: Louis Garman <[email protected]>
- Loading branch information
1 parent
df1645d
commit 4c2c130
Showing
2 changed files
with
11 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters