Fix line number for variabled inside var group #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would show the line number of the 'var' token, not the correct line where the variable is actually specified.
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
=======================================
Coverage 59.15% 59.15%
=======================================
Files 2 2
Lines 71 71
=======================================
Hits 42 42
Misses 27 27
Partials 2 2
Continue to review full report at Codecov.
|
leonklingele
force-pushed
the
fix-var-group-line
branch
from
bfe39be to
1f78a5d
Compare
|
Fixed typo in commit message. |
leighmcculloch
approved these changes
Jan 18, 2019
leonklingele
added a commit
to leonklingele/gometalinter
that referenced
this pull request
Jan 21, 2019
This fixes the line number for variables inside a 'var' group. See leighmcculloch/gochecknoglobals#9
alecthomas
pushed a commit
to alecthomas/gometalinter
that referenced
this pull request
Jan 21, 2019
This fixes the line number for variables inside a 'var' group. See leighmcculloch/gochecknoglobals#9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would show the line number of the 'var' token, not
the correct line where the variable is actually specified.