Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only group delete visible items #4798

Merged
merged 3 commits into from
Feb 7, 2022
Merged

Only group delete visible items #4798

merged 3 commits into from
Feb 7, 2022

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Feb 2, 2022

Signed-off-by: Sebastian Malton [email protected]

fixes #4745

Screen.Recording.2022-02-02.at.10.36.18.AM.mov

@Nokel81 Nokel81 added the bug Something isn't working label Feb 2, 2022
@Nokel81 Nokel81 added this to the 5.4.0 milestone Feb 2, 2022
@Nokel81 Nokel81 requested a review from a team as a code owner February 2, 2022 15:42
@Nokel81 Nokel81 requested review from nevalla and jim-docker and removed request for a team February 2, 2022 15:42
aleksfront
aleksfront previously approved these changes Feb 3, 2022
Copy link
Contributor

@aleksfront aleksfront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: Sebastian Malton <[email protected]>
Signed-off-by: Sebastian Malton <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2022

Conflicts have been resolved. A maintainer will review the pull request shortly.

aleksfront
aleksfront previously approved these changes Feb 3, 2022
ixrock
ixrock previously approved these changes Feb 7, 2022
Signed-off-by: Sebastian Malton <[email protected]>
@Nokel81 Nokel81 dismissed stale reviews from ixrock and aleksfront via aa503c3 February 7, 2022 13:57
@Nokel81
Copy link
Collaborator Author

Nokel81 commented Feb 7, 2022

@ixrock @jim-docker @aleksfront PTALA, I have fixed the PortForwardStore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selected but not visible items in a list will get removed
4 participants