Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename KubernetesCluster MenuItem from Delete to Remove #4854

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Rename KubernetesCluster MenuItem from Delete to Remove #4854

merged 2 commits into from
Feb 14, 2022

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Feb 11, 2022

Signed-off-by: Sebastian Malton [email protected]

fixes #4846

@Nokel81 Nokel81 added this to the 5.4.0 milestone Feb 11, 2022
@Nokel81 Nokel81 requested a review from a team as a code owner February 11, 2022 15:32
@Nokel81 Nokel81 requested review from jakolehm and jim-docker and removed request for a team February 11, 2022 15:32
stefcameron
stefcameron previously approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@stefcameron stefcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Nokel81
Fix integration test
a4b6373 
Signed-off-by: Sebastian Malton <[email protected]>
stefcameron
stefcameron approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@stefcameron stefcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Nokel81 Nokel81 merged commit 46585ee into master Feb 14, 2022
@Nokel81 Nokel81 deleted the rename-kc-menu-item branch February 14, 2022 14:24
@jim-docker jim-docker mentioned this pull request Feb 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansav jansav jansav approved these changes

@stefcameron stefcameron stefcameron approved these changes

@jweak jweak jweak approved these changes

@jakolehm jakolehm Awaiting requested review from jakolehm jakolehm is a code owner automatically assigned from lensapp/lens-ide

@jim-docker jim-docker Awaiting requested review from jim-docker jim-docker is a code owner automatically assigned from lensapp/lens-ide

Assignees
No one assigned
Labels
area/ui chore
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.

"Delete" action for a cluster in Lens should be renamed to "Remove"
4 participants
@Nokel81 @jweak @stefcameron @jansav