Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: closing terminal tab error #4874

Merged
merged 2 commits into from
Feb 16, 2022
Merged

Fix: closing terminal tab error #4874

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8888550
Check if this.socket is available
aleksfront Feb 16, 2022
8eec216
Convert socket to be optional
aleksfront Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/renderer/api/websocket-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export interface WebSocketEvents {
type Defaulted<Params, DefaultParams extends keyof Params> = Required<Pick<Params, DefaultParams>> & Omit<Params, DefaultParams>;

export class WebSocketApi<Events extends WebSocketEvents> extends (EventEmitter as { new<T>(): TypedEventEmitter<T> })<Events> {
protected socket: WebSocket;
protected socket?: WebSocket | null;
protected pendingCommands: (string | ArrayBufferLike | Blob | ArrayBufferView)[] = [];
protected reconnectTimer?: any;
protected pingTimer?: any;
Expand Down Expand Up @@ -181,7 +181,7 @@ export class WebSocketApi<Events extends WebSocketEvents> extends (EventEmitter
if (error) {
const { reconnectDelay } = this.params;

if (reconnectDelay) {
if (reconnectDelay && this.socket) {
aleksfront marked this conversation as resolved.
Show resolved Hide resolved
const url = this.socket.url;

this.writeLog("will reconnect in", `${reconnectDelay}s`);
Expand Down