-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding spacing between Metrics Settings sections #6632
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Andreev <[email protected]>
aleksfront
requested review from
jansav and
Iku-turso
and removed request for
a team
November 23, 2022 09:30
Iku-turso
approved these changes
Nov 23, 2022
Nokel81
pushed a commit
that referenced
this pull request
Nov 24, 2022
Signed-off-by: Alex Andreev <[email protected]> Signed-off-by: Alex Andreev <[email protected]>
Merged
Nokel81
added a commit
that referenced
this pull request
Nov 24, 2022
* Release 6.2.2 Signed-off-by: Sebastian Malton <[email protected]> * fix: getAllowedResources for all namespaces using SelfSubjectRulesReview (#6614) * fix: getAllowedResources for all namespaces using SelfSubjectRulesReview Signed-off-by: Andreas Hippler <[email protected]> * fix: refresh accessibility every 15 min Signed-off-by: Andreas Hippler <[email protected]> * chore: remove unused clusterRefreshHandler Signed-off-by: Andreas Hippler <[email protected]> * fix: resolve SelfSubjectRulesReview globs Signed-off-by: Andreas Hippler <[email protected]> Signed-off-by: Andreas Hippler <[email protected]> Co-authored-by: Andreas Hippler <[email protected]> Signed-off-by: Sebastian Malton <[email protected]> * Add missing gutter between sections in cluster settings (#6631) Signed-off-by: Janne Savolainen <[email protected]> Signed-off-by: Janne Savolainen <[email protected]> * Adding spacing between Metrics Settings sections (#6632) Signed-off-by: Alex Andreev <[email protected]> Signed-off-by: Alex Andreev <[email protected]> * Fix crash when upgrading release (#6626) * Fix crash when upgrading release Signed-off-by: Sebastian Malton <[email protected]> * Fix crash when upgrading helm releases - Fixes not being able to upgrade helm releases as well. Signed-off-by: Sebastian Malton <[email protected]> * Fix tests Signed-off-by: Sebastian Malton <[email protected]> * Fix test failures Signed-off-by: Sebastian Malton <[email protected]> Signed-off-by: Sebastian Malton <[email protected]> * Removing big padding after cluster settings avatar (#6634) Signed-off-by: Alex Andreev <[email protected]> Signed-off-by: Alex Andreev <[email protected]> * Fix KubeApi watch retry on timeout (#6640) * fix KubeApi watch retry on timeout Signed-off-by: Jari Kolehmainen <[email protected]> * Fix tests Signed-off-by: Sebastian Malton <[email protected]> Signed-off-by: Jari Kolehmainen <[email protected]> Signed-off-by: Sebastian Malton <[email protected]> Co-authored-by: Sebastian Malton <[email protected]> * Bump electron from 19.1.6 to 19.1.7 (#6637) Bumps [electron](https://github.com/electron/electron) from 19.1.6 to 19.1.7. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md) - [Commits](electron/electron@v19.1.6...v19.1.7) --- updated-dependencies: - dependency-name: electron dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Sebastian Malton <[email protected]> Signed-off-by: Andreas Hippler <[email protected]> Signed-off-by: Janne Savolainen <[email protected]> Signed-off-by: Alex Andreev <[email protected]> Signed-off-by: Jari Kolehmainen <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Andreas Hippler <[email protected]> Co-authored-by: Andreas Hippler <[email protected]> Co-authored-by: Janne Savolainen <[email protected]> Co-authored-by: Alex Andreev <[email protected]> Co-authored-by: Jari Kolehmainen <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #6437 all
<section>
tags dropped generic styles for margin.This PR fixes spacing in bundled metrics settings extension.
Before:
After:
Signed-off-by: Alex Andreev [email protected]