Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update button being visible when download for update fails #7336

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

jansav
Copy link
Contributor

@jansav jansav commented Mar 10, 2023

Download for an update fails when e.g. computer is in sleep mode without access for network.

installing update
    when started
    ✓ checks for updates
    ✓ shows tray icon for checking for updates
    ✓ renders
    when no new update is discovered
      ✓ shows tray icon for normal
      ✓ does not start downloading update
      ✓ renders
    when new update is discovered
      ✓ starts downloading the update
      ✓ still shows tray icon for downloading
      ✓ renders
      when download fails
        ✓ does not quit and install update yet
        ✓ still shows normal tray icon
        ✓ renders
        ✕ does not show the update button
        
        given time passes and checking for updates again
          ✕ does not show the update button

Fixes #7334

@jansav jansav added the bug Something isn't working label Mar 10, 2023
@jansav jansav added this to the 6.4.7 milestone Mar 10, 2023
@jansav jansav requested a review from a team as a code owner March 10, 2023 09:47
@jansav jansav requested review from Nokel81 and jim-docker and removed request for a team March 10, 2023 09:47
@jansav jansav force-pushed the fix/update-button-being-visible-when-download-fails branch from 2735461 to fef9b93 Compare March 10, 2023 10:24
Copy link
Contributor

@jweak jweak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nokel81 Nokel81 merged commit a5928d0 into master Mar 10, 2023
@Nokel81 Nokel81 deleted the fix/update-button-being-visible-when-download-fails branch March 10, 2023 13:34
Nokel81 pushed a commit that referenced this pull request Mar 17, 2023
@Nokel81 Nokel81 mentioned this pull request Mar 17, 2023
Nokel81 added a commit that referenced this pull request Mar 17, 2023
* Exporting ResourceMetrics and PodCharts to extension API (#7326)

Signed-off-by: Alex Andreev <[email protected]>

* Fix update button being visible when download for update fails (#7336)

Signed-off-by: Janne Savolainen <[email protected]>

* Update repository in statefulset template from k8s.gcr.io to registry.k8s (#7338)

Signed-off-by: EnriqueTejeda <[email protected]>

* Fix cluster view broken scrolling (#7349)

Signed-off-by: Alex Andreev <[email protected]>

* Release 6.4.7

Signed-off-by: Sebastian Malton <[email protected]>

* Fix release tool

Signed-off-by: Sebastian Malton <[email protected]>

---------

Signed-off-by: Alex Andreev <[email protected]>
Signed-off-by: Janne Savolainen <[email protected]>
Signed-off-by: EnriqueTejeda <[email protected]>
Signed-off-by: Sebastian Malton <[email protected]>
Co-authored-by: Alex Andreev <[email protected]>
Co-authored-by: Janne Savolainen <[email protected]>
Co-authored-by: Enrique Tejeda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto update fails to install
3 participants