Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Remove the reg key close on hdata performance #42

Closed
wants to merge 2 commits into from
Closed

Remove the reg key close on hdata performance #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8234570
Remove the reg key, if you wrap the error during running you will see…
mattdurham May 11, 2023
b9ba65c
fix formatting
mattdurham May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ tools/dumps
*.exe
_*.go
*~
vendor/
3 changes: 0 additions & 3 deletions perflib/perflib.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,6 @@ func queryRawData(query string) ([]byte, error) {
return nil, fmt.Errorf("failed to encode query string: %v", err)
}

defer syscall.RegCloseKey(syscall.HKEY_PERFORMANCE_DATA)

for {
bufLen := uint32(len(buffer))

Expand All @@ -237,7 +235,6 @@ func queryRawData(query string) ([]byte, error) {
newBuffer := make([]byte, len(buffer)+16384)
copy(newBuffer, buffer)
buffer = newBuffer
syscall.RegCloseKey(syscall.HKEY_PERFORMANCE_DATA)
continue
} else if err != nil {
if errno, ok := err.(syscall.Errno); ok {
Expand Down