feat: add cwd argument to delve #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 25, 2024
Closed
leoluz
requested changes
Apr 28, 2024
| @@ -55,6 +55,7 @@ local function setup_delve_adapter(dap, config) | |||
| command = config.delve.path, | |||
| args = args, | |||
| detached = config.delve.detached, | |||
| cwd = config.delve.cwd, | |||
There was a problem hiding this comment.
Not sure why this is necessary. This setup_delve_adapter() function is only executed when nvim-dap starts the delve server in DAP mode. The cwd shouldn't matter in this case as it is the client who provides the necessary parameters to start a debug session. Can you please clarify why this is necessary?
leoluz
approved these changes
May 2, 2024
There was a problem hiding this comment.
Is discussed in the issue this feature is incomplete but acceptable to be merged.
Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #80