fix: automatically set attached mode for delve based on OS #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leoluz What is the actual issue referenced in the current code? For me it crashed if not setting this flag to false in Windows, but with dlv 1.22.1 this seems to no longer be true. |
Scratch that, it still happens if not false. I must not have reloaded settings. |
|
This fixes the config to work out of the box for different platforms. It seems to be the issue faced in this stackoverflow post. This probably should be merged. |
leoluz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Here's a change to automatically set the attached mode for delve so the end-user doesn't have to.
I added it to the config example too but maybe that entire line should be removed with this fix in place, let me know if I should do that.
Br,